eloqkv.ini (1)

179-194: Move LOCAL STANDBY configuration block outside CLOUD MODE section; these configs are not yet implemented in the codebase.

The LOCAL STANDBY block is placed within the "CLOUD MODE CONFIGURATION" section (lines 136-140), creating confusion since line 180 explicitly states to "keep this disabled in cloud mode." Additionally, these configuration keys are not referenced anywhere in the codebase, indicating this is forward-looking documentation for a feature not yet implemented.

To improve clarity:

1. Move the LOCAL STANDBY block outside the "CLOUD MODE CONFIGURATION" section, or add a clear subsection header like # >>>>>>>>>>>>> LOCAL STANDBY (NON-CLOUD) <<<<<<<<<<<<<
2. Consider adding validation guidance for when the feature is implemented:
   • What happens if eloq_store_standby_master_snapshot_roots count doesn't match the actual snapshot roots on the master?
   • What happens if eloq_store_standby_master_store_path_weights count doesn't match the master's store path list?
3. Clarify the host_name:/path format when the host includes a port (e.g., host:port:/path vs host:/path)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@eloqkv.ini` around lines 179 - 194, Move the LOCAL STANDBY configuration
block (keys eloq_store_enable_local_standby, eloq_store_standby_master_path,
eloq_store_standby_master_snapshot_roots,
eloq_store_standby_master_store_path_weights) out of the "CLOUD MODE
CONFIGURATION" section or prepend a distinct subsection header like "LOCAL
STANDBY (NON-CLOUD)" to avoid implying cloud compatibility; mark these keys as
not yet implemented in the codebase, and add short TODO/validation notes
indicating required behavior once implemented (e.g., how mismatched counts for
eloq_store_standby_master_snapshot_roots vs master snapshot roots and
eloq_store_standby_master_store_path_weights vs master store paths should be
handled), and clarify the host:path format rules including how to represent a
host with a port (explicitly state expected syntax such as
username@host:port:/absolute/path or an alternative).

eloqkv.ini (1)

192-194: Make standby weight cardinality explicit.

Please explicitly state that eloq_store_standby_master_store_path_weights count must equal eloq_store_standby_master_store_paths count (similar to Line 96-97), to prevent misconfiguration ambiguity.

Suggested wording

-# [LOCAL STANDBY OPTIONAL] Store path weights for the standby master, separated by ','.
-# Use the same ordering as the standby master's store path list.
+# [LOCAL STANDBY OPTIONAL] Store path weights for the standby master, separated by ','.
+# The number of weights must match eloq_store_standby_master_store_paths.
+# Use the same ordering as the standby master's store path list.
 # eloq_store_standby_master_store_path_weights=

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@eloqkv.ini` around lines 192 - 194, Update the comment for
eloq_store_standby_master_store_path_weights to explicitly state that the number
of comma-separated weights must match the number of entries in
eloq_store_standby_master_store_paths (i.e., they must have the same
cardinality), mirroring the guidance used earlier for the primary store paths;
mention the requirement clearly so users know to provide one weight per standby
store path and note that omission or mismatch is invalid.